Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue 4956: 'Linode DNS Pagination Bug' #5172

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

vmmello
Copy link

@vmmello vmmello commented Jun 11, 2024

fixes issue #4956

previous code only worked for the first 10 domains on the account (as Linode API returned a paginated response, with only 10 records).

This change makes an exact search query for each subdomain, completely removing any need for walking through paginated responses. What makes it work for large accounts with any number of domains.

Neilpang and others added 4 commits April 1, 2024 11:46
fixes issue acmesh-official#4956

previous code only worked for the first 10 domains on the account (as Linode
API returned a paginated response, with only 10 records).

This change makes an exact search query for each subdomain, completely removing any
need for walking through paginated responses. What makes it work for large
accounts with any number of domains.
Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

minor fix for text coherence
fix minor problems reported by shellcheck and shfmt
@vmmello
Copy link
Author

vmmello commented Sep 23, 2024

Can this be merged into dev, please?

@Neilpang
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants